On Mon, May 08, 2023 at 03:07:31PM +0300, Tomi Valkeinen wrote: > On 08/05/2023 15:04, Sakari Ailus wrote: > > Hi Tomi, > > > > Thank you for the review. > > > > On Mon, May 08, 2023 at 12:52:24PM +0300, Tomi Valkeinen wrote: > > > On 06/05/2023 00:52, Sakari Ailus wrote: > > > > Internal source pads will be used as routing endpoints in V4L2 > > > > [GS]_ROUTING IOCTLs, to indicate that the stream begins in the entity. > > > > > > > > Also prevent creating links to pads that have been flagged as internal. > > > > > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > > > --- > > > > .../userspace-api/media/mediactl/media-types.rst | 7 +++++++ > > > > drivers/media/mc/mc-entity.c | 8 +++++++- > > > > include/uapi/linux/media.h | 1 + > > > > 3 files changed, 15 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/Documentation/userspace-api/media/mediactl/media-types.rst b/Documentation/userspace-api/media/mediactl/media-types.rst > > > > index 0ffeece1e0c8..c724139ad46c 100644 > > > > --- a/Documentation/userspace-api/media/mediactl/media-types.rst > > > > +++ b/Documentation/userspace-api/media/mediactl/media-types.rst > > > > @@ -361,6 +361,7 @@ Types and flags used to represent the media graph elements > > > > .. _MEDIA-PAD-FL-SINK: > > > > .. _MEDIA-PAD-FL-SOURCE: > > > > .. _MEDIA-PAD-FL-MUST-CONNECT: > > > > +.. _MEDIA-PAD-FL-INTERNAL-SOURCE: > > > > .. flat-table:: Media pad flags > > > > :header-rows: 0 > > > > @@ -382,6 +383,12 @@ Types and flags used to represent the media graph elements > > > > when this flag isn't set; the absence of the flag doesn't imply > > > > there is none. > > > > + * - ``MEDIA_PAD_FL_INTERNAL_SOURCE`` > > > > + - This flag indicates an internal pad that has no external > > > > + connections. Such a pad may not be connected with a link. The internal > > > > > > "must not"? Or "shall not"? > > > > I think "may not" is appropriate. I'd be fine with shall, too, albeit it > > wouldn't change the meaning in practice. > > Ok. I don't speak standardize, and I'm not a native English speaker. But to > me "may not be connected" sounds like it is possibly not connected, but also > that it is possible for it to be connected. Ah, yes, I think you're actually right. But that is what I thought when writing the text. ;-) Shall we use shall, then? -- Sakari Ailus
