Hi Sakari, On Mon, May 08, 2023 at 09:19:24AM +0300, Sakari Ailus wrote: > On Sat, May 06, 2023 at 02:32:23PM +0300, Laurent Pinchart wrote: > > On Fri, May 05, 2023 at 11:51:01PM +0300, Sakari Ailus wrote: > > > Use unsigned int values annoted by "U" for u32 fields. While this is a > > > good practice, there doesn't appear to be a bug that this patch would fix. > > > > > > The patch has been generated using the following command: > > > > > > perl -i -pe 's/\([0-9]+\K <</U <</g' -- include/uapi/linux/media.h > > > > How about using the _BITUL() macro from include/uapi/linux/const.h ? > > These are u32 whereas _BITUL makes an unsigned long. Int (as in U) is 32 > bits on all platforms where Linux is used AFAIK. I know, but is it a problem ? > And thanks for the review! -- Regards, Laurent Pinchart
