On 2023/5/5 14:40, Krzysztof Kozlowski wrote: > On 05/05/2023 07:57, Jack Zhu wrote: >> >> >> On 2023/4/24 19:19, Jack Zhu wrote: >>> >>> >>> On 2023/4/13 11:55, Jack Zhu wrote: >>>> Hi, >>>> >>>> This patch series adds support for the StarFive Camera Subsystem >>>> found on StarFive JH7110 SoC. >>>> >>>> The driver implements V4L2, Media controller and V4L2 subdev interfaces. >>>> Camera sensor using V4L2 subdev interface in the kernel is supported. >>>> >>>> The driver is tested on VisionFive V2 board with IMX219 camera sensor. >>>> GStreamer 1.18.5 with v4l2src plugin is supported. >>>> >>>> Changes since v3: >>>> Patch 1: >>>> - Modified port@0 and port@1 properties. >>>> - Extended the port@0 example with appropriate properties. >>>> - Added 'port@0' for 'required' >>>> Patch 2: >>>> - Modified spelling errors. >>>> Patch 3: >>>> - Merged patch 5 into the patch with an explanation for compatible in >>>> commit msg. >>>> Patch 6: >>>> - Asserted pixel_rst[i] reset in the loop after the err_disable_pixclk >>>> label. >>>> - Modified Code Style for getting sys_rst and p_rst. >>>> - Renamed clk_name to name and modified the relevant code. >>>> Patch 9: >>>> - Added static for stfcamss_get_mem_res function. >>>> - Added static for isp_close function. >>>> - Fixed implicit conversion warning for stf_vin_map_isp_pad function. >>>> - Dropped unused variables. >>>> >>>> v3: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@xxxxxxxxxxxxxxxx/ >>>> >>> >>> Hello everyone, >>> >>> From the current review status, the patches related to the CSI module >>> have 'reviewed-by' tags. I would like to know if it is okay to add >>> patches 1-5 from this series to a PR first. >>> >>> Thank you! >>> >>> Jack >>> >> >> Hello Mauro, Laurent, Maxime, Rob, Krzysztof, Robert, Todor and Philipp, >> >> Can you give me some suggestions and comments on the previous request >> to commit CSI related patches first? Thank you for your time. > > You received very specific feedback, so know you decided to ignore it? > > No, implement what you were asked for. > Hi Krzysztof, Thank you for your comments. I am talking about CSI-related patches 1-5, not including the patches 6-8. The CSI module is a relatively functionally independent hardware module. The CSI-related patches 1-5 already have 'reviewed-by' tags, and there are no unprocessed comments left. So, made the previous request. Please let me know if I understand something wrong. I don't want to ignore any comments, I will continue to modify the isp patches 6-8 in subsequent versions according to your comments. The ISP-related patches are being prepared. Jack > Best regards, > Krzysztof >
