On 19/04/2023 22:24, Henrik Grimler wrote: >> /* >> * The second parameter of SMC_CMD_CPU1BOOT command means CPU id. >> + * But, Exynos4212 has only one secondary CPU so second parameter >> + * isn't used for informing secure firmware about CPU id. >> */ >> + if (soc_is_exynos4212()) >> + cpu = 0; > > Is it necessary to set cpu = 0? Are there any obvious issues without > it (like second cpu not being brought up)? Just tested this; looks like it's required here, without it the second core fails to start up: [ 0.064277] smp: Bringing up secondary CPUs ... [ 1.067163] CPU1: failed to boot: -110 [ 1.069683] smp: Brought up 1 node, 1 CPU [ 1.072470] SMP: Total of 1 processors activated (48.00 BogoMIPS). SBOOT on my tablet claims the version is T310XXSBQB2, so it should match with the one you checked. Best regards Artur Weber
