Hi Laurent, On Tue, Apr 25, 2023 at 04:06:54AM +0300, Laurent Pinchart wrote: > > -/** > > - * __v4l2_async_nf_add_connection() - Add an async subdev to the notifier's > > - * master asc list. > > - * > > - * @notifier: pointer to &struct v4l2_async_notifier > > - * @asc: pointer to &struct v4l2_async_connection > > - * > > - * \warning: Drivers should avoid using this function and instead use one of: > > - * v4l2_async_nf_add_fwnode(), > > - * v4l2_async_nf_add_fwnode_remote() or > > - * v4l2_async_nf_add_i2c(). > > - * > > - * Call this function before registering a notifier to link the provided @asc to > > - * the notifiers master @asc_list. The @asc must be allocated with k*alloc() as > > - * it will be freed by the framework when the notifier is destroyed. > > - */ > > You could move this documentation to the .c file (dropping the warning). > There's little documentation of internal function for v4l2-async, which > makes the code hard to understand. Let's not make it worse by dropping > existing documentation :-) As this is no longer usable by drivers, I'm not sure how relevant keeping this around for just v4l2-async internal use is. For instance, did I read any of these comments when writing this patchset? I can say I did not read a single one of them. They are not specific enough for understanding the implementation anyway, this is written for driver authors in mind. Instead what can and probably should be added are object relations and why certain non-obvious things are done the way they are. I'll add this for the patches when the code as such seems fine. I'll address the rest of the comments in v2. -- Regards, Sakari Ailus
