Hi Laurent, On Tue, Apr 25, 2023 at 04:15:41AM +0300, Laurent Pinchart wrote: > Hi Sakari, > > Thank you for the patch. > > On Thu, Mar 30, 2023 at 02:58:40PM +0300, Sakari Ailus wrote: > > There's a need to verify that a single async sub-device isn't being added > > multiple times, this would be an error. This takes place at the time of > > adding the async sub-device to the notifier's list as well as when the > > notifier is added to the global notifier's list. > > > > Use the pointer to the sub-device for testing this instead of an index to > > an array that is long gone. > > Reading the patch, I have no idea what the "long gone array" is. Could > you please expand the commit message to make this easier to review ? Yes... the async sub-devices were placed in an array earlier, that's what the index was referring to. Although this could be an entry in a linked list. Not how they are usually referred to though. This will go away permanently later on in the set. I'll add this to the commit message. > v4l2-async is very difficult to follow in general, reviewing this series > is painful :-S Let's try to improve it with better commit messages. -- Regards, Sakari Ailus
