Hi Sakari,
Thank you for the patch.
On Thu, Mar 30, 2023 at 02:58:49PM +0300, Sakari Ailus wrote:
> Initialise the V4L2 async notifier after registering the V4L2 device, just
> before parsing DT for async sub-devices. This way struct device is
> available to the notifier right from the beginning.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/xilinx/xilinx-vipp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> index 70e7a1f6ed3b..83430633ed28 100644
> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> @@ -516,6 +516,8 @@ static int xvip_graph_init(struct xvip_composite_device *xdev)
> goto done;
> }
>
> + v4l2_async_nf_init(&xdev->notifier);
> +
> /* Parse the graph to extract a list of subdevice DT nodes. */
> ret = xvip_graph_parse(xdev);
> if (ret < 0) {
> @@ -596,7 +598,6 @@ static int xvip_composite_probe(struct platform_device *pdev)
>
> xdev->dev = &pdev->dev;
> INIT_LIST_HEAD(&xdev->dmas);
> - v4l2_async_nf_init(&xdev->notifier);
>
> ret = xvip_composite_v4l2_init(xdev);
> if (ret < 0)
--
Regards,
Laurent Pinchart
