Hello Hans, all, On Fri, 21 Apr 2023 16:23:14 +0000 Jenkins <jenkins@xxxxxxxxxxx> wrote: > From: builder@xxxxxxxxxxx > > Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/52fb6582-f571-561c-5168-1d1bfc88dbc7@xxxxxxxxx/ > Build log: https://builder.linuxtv.org/job/patchwork/299677/ > Build time: 00:24:37 > Link: https://lore.kernel.org/linux-media/52fb6582-f571-561c-5168-1d1bfc88dbc7@xxxxxxxxx > > gpg: Signature made Fri 21 Apr 2023 03:19:33 PM UTC > gpg: using EDDSA key 52ADCAAE8A4F70B99ACD8D726B425DF79B1C1E76 > gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xxxxxxxxx>" [unknown] > gpg: aka "Hans Verkuil <hverkuil@xxxxxxxxx>" [full] > > Summary: got 2/20 patches with issues, being 1 at build time, plus one error when buinding PDF document > > Error/warnings: > > patches/0001-dt-bindings-display-tegra-add-Tegra20-VIP.patch: > > allyesconfig: return code #0: > ../scripts/genksyms/parse.y: warning: 9 shift/reduce conflicts [-Wconflicts-sr] > ../scripts/genksyms/parse.y: warning: 5 reduce/reduce conflicts [-Wconflicts-rr] > ../scripts/genksyms/parse.y: note: rerun with option '-Wcounterexamples' to generate conflict counterexamples > ../drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:212 gc0310_s_stream() warn: missing error code 'ret' > ../drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:416 ov2680_s_stream() warn: missing error code 'ret' > ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3013 atomisp_cp_dvs_6axis_config() warn: missing unwind goto? > ../drivers/staging/media/atomisp/pci/atomisp_cmd.c: ../drivers/staging/media/atomisp/pci/atomisp_cmd.c:3112 atomisp_cp_morph_table() warn: missing unwind goto? > > allyesconfig: return code #0: > ../drivers/media/i2c/adp1653.c: ../drivers/media/i2c/adp1653.c:444 adp1653_of_init() warn: missing unwind goto? > ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c: ../drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2775 mxc_jpeg_probe() warn: missing unwind goto? > ../drivers/media/i2c/ov5645.c: ../drivers/media/i2c/ov5645.c:687 ov5645_set_power_on() warn: 'ov5645->xclk' from clk_prepare_enable() not released on lines: 687. > SMATCH:../drivers/media/usb/siano/smsusb.c ../drivers/media/usb/siano/smsusb.c:53:38: :warning: array of flexible structures > ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: OOM: 3000012Kb sm_state_count = 1974506 > ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() warn: Function too hairy. No more merges. > ../drivers/media/pci/cx23885/cx23885-dvb.c: ../drivers/media/pci/cx23885/cx23885-dvb.c:2570 dvb_register() parse error: __split_smt: function too hairy. Giving up after 55 seconds > ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c: ../drivers/media/usb/pvrusb2/pvrusb2-hdw.c:3293 pvr2_hdw_get_tuner_status() warn: inconsistent indenting I see no correlation with my patch here. > patches/0020-staging-media-tegra-video-add-support-for-Tegra20-pa.patch: > > checkpatch.pl: > $ cat patches/0020-staging-media-tegra-video-add-support-for-Tegra20-pa.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict > -:54: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? This is bogus: I added myself in MAINTAINERS in patch 1. > -:103: CHECK: Prefer using the BIT macro > -:134: CHECK: Prefer using the BIT macro Bogus as well. It is asking to use BIT() in the 2nd line here: +#define VI_INPUT_YUV_INPUT_FORMAT_UYVY (0 << VI_INPUT_YUV_INPUT_FORMAT_SFT) +#define VI_INPUT_YUV_INPUT_FORMAT_VYUY (1 << VI_INPUT_YUV_INPUT_FORMAT_SFT) +#define VI_INPUT_YUV_INPUT_FORMAT_YUYV (2 << VI_INPUT_YUV_INPUT_FORMAT_SFT) +#define VI_INPUT_YUV_INPUT_FORMAT_YVYU (3 << VI_INPUT_YUV_INPUT_FORMAT_SFT) and the same in a similar section below. Best regards, Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
