Re: [PATCH] uvc: Enable USB autosuspend by default on uvcvideo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Matthew,

Thanks for the patch.

On Thursday 16 September 2010 20:00:04 Matthew Garrett wrote:
> We've been doing this for a while in Fedora without any complaints.

I'll trust you on that. If users start complaining I'll tell them who to blame 
;-)

> Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>

Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

(although, if you need to resubmit the patch for any reason, I'd rather like 
the usb_enable_autosuspend call to be before the uvc_trace call).

> ---
>  drivers/media/video/uvc/uvc_driver.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/video/uvc/uvc_driver.c
> b/drivers/media/video/uvc/uvc_driver.c index 8bdd940..28ed5b4 100644
> --- a/drivers/media/video/uvc/uvc_driver.c
> +++ b/drivers/media/video/uvc/uvc_driver.c
> @@ -1814,6 +1814,7 @@ static int uvc_probe(struct usb_interface *intf,
>  	}
> 
>  	uvc_trace(UVC_TRACE_PROBE, "UVC device initialized.\n");
> +	usb_enable_autosuspend(udev);
>  	return 0;
> 
>  error:

-- 
Regards,

Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux