Hi Jacopo,
On Fri, Apr 14, 2023 at 09:15:23AM +0200, Jacopo Mondi wrote:
> > static int v4l2_async_nf_asd_valid(struct v4l2_async_notifier *notifier,
> > - struct v4l2_async_subdev *asd,
> > + struct v4l2_async_match *match,
>
> I would have kept the asd here, but I presume having match here makes
> things easier in the next patches
The other fields won't be needed there, that's why I'd pass just the match
information.
>
>
> > bool skip_self)
> > {
> > struct device *dev =
> > notifier->v4l2_dev ? notifier->v4l2_dev->dev : NULL;
> >
> > - if (!asd)
> > + if (!match)
> > return -EINVAL;
>
> Match cannot be null, as it's a member of struct v4l2_async_subdev
Indeed. I'll add another patch to drop the check, it doesn't seem to be
needed to begin with.
--
Kind regards,
Sakari Ailus
