On Thu, Sep 16, 2010 at 01:32:07PM +0200, David Härdeman wrote: > On Thu, September 16, 2010 07:22, Jarod Wilson wrote: > > This is a stab at separating the mouse (and front panel/knob) events > > out to a separate input device. This is necessary in preparation for > > the next patch which makes the rc-core input dev opaque to rc > > drivers. > > > > I can't verify the correctness of the patch beyond the fact that it > > compiles without warnings. The driver has resisted most of my > > attempts at understanding it properly...for example, the double calls > > to le64_to_cpu() and be64_to_cpu() which are applied in > > imon_incoming_packet() and imon_panel_key_lookup() would amount > > to a bswab64() call, irregardless of the cpu endianness, and I think > > the code wouldn't have worked on a big-endian machine... > > > > Signed-off-by: David Härdeman <david@xxxxxxxxxxx> > > > > - Minor alterations to apply with minimal core IR changes > > - Use timer for imon keys too, since its entirely possible for the > > receiver to miss release codes (either by way of another key being > > pressed while the first is held or by the remote pointing away from > > the recevier when the key is release. yes, I know, its ugly). > > Where's the additional timer usage exactly? I can't see any in the patch... For ktype == IMON_KEY_IMON in your original patch, keys were submitted with ir_keydown_notimeout, and in this version, they're submitted with plain old ir_keydown, which has a built-in timeout. -- Jarod Wilson jarod@xxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
