On Fri, Apr 07, 2023 at 04:44:07AM +0300, Laurent Pinchart wrote:
> Hi Alexander,
>
> Thank you for the patch.
>
> On Thu, Apr 06, 2023 at 11:55:51AM +0200, Alexander Stein wrote:
> > Also dev_err_probe message require a trailing \n.
>
> There should be a blank line here.
>
> > Fixes: 63127235bebd ("media: i2c: imx290: Use dev_err_probe()")
> >
>
> And none here.
>
> But the bug wasn't introduced in the above commit, the \n was missing
> before that, right from the start when the driver was merged in commit
> 828dbc299278 ("media: i2c: Add IMX290 CMOS image sensor driver"). I
> would use that commit in the Fixes tag, or drop the Fixes tag
> altogether.
I dropped it. This is not a grave problem.
>
> > Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Thanks!
--
Sakari Ailus
