Re: [PATCH v7 0/4] media: camss: sm8250: Virtual channels support for SM8250

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/04/2023 13:16, Milen Mitkov (Consultant) wrote:

On 03/04/2023 15:10, Bryan O'Donoghue wrote:
On 03/04/2023 12:01, Milen Mitkov (Consultant) wrote:
Hi Bryan,

no, the iteration through the mask didn't go away? The print shows up when the csid entity's source pad(s) enables the link to the ife sink pad(s). Maybe the client (libcamera?) decides to disable this link for some reason?

Regards,

Milen

So previously we had one CSI device in user-space and after your change we have one CSI device per VC, correct ?

---
bod

With these changes there's still one CSID device/media entity, but it has more source pads (4 vs 1 previously).

Regards,

Milen


OK.

I took the time to apply this series to my development tree.

Before:
- entity 19: msm_csid0 (2 pads, 10 links)
             type V4L2 subdev subtype Unknown flags 0
             device node name /dev/v4l-subdev6
        pad0: Sink
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                <- "msm_csiphy0":1 []
                <- "msm_csiphy1":1 []
                <- "msm_csiphy2":1 []
                <- "msm_csiphy3":1 []
                <- "msm_csiphy4":1 []
                <- "msm_csiphy5":1 []
        pad1: Source
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                -> "msm_vfe0_rdi0":0 []
                -> "msm_vfe1_rdi0":0 []
                -> "msm_vfe2_rdi0":0 []
                -> "msm_vfe3_rdi0":0 []

After:
- entity 19: msm_csid0 (5 pads, 22 links)
             type V4L2 subdev subtype Unknown flags 0
             device node name /dev/v4l-subdev6
        pad0: Sink
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                <- "msm_csiphy0":1 []
                <- "msm_csiphy1":1 []
                <- "msm_csiphy2":1 [ENABLED]
                <- "msm_csiphy3":1 []
                <- "msm_csiphy4":1 []
                <- "msm_csiphy5":1 []
        pad1: Source
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                -> "msm_vfe0_rdi0":0 [ENABLED]
                -> "msm_vfe1_rdi0":0 []
                -> "msm_vfe2_rdi0":0 []
                -> "msm_vfe3_rdi0":0 []
        pad2: Source
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                -> "msm_vfe0_rdi1":0 []
                -> "msm_vfe1_rdi1":0 []
                -> "msm_vfe2_rdi1":0 []
                -> "msm_vfe3_rdi1":0 []
        pad3: Source
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                -> "msm_vfe0_rdi2":0 []
                -> "msm_vfe1_rdi2":0 []
                -> "msm_vfe2_rdi2":0 []
                -> "msm_vfe3_rdi2":0 []
        pad4: Source
                [fmt:UYVY8_2X8/1920x1080 field:none colorspace:srgb]
                -> "msm_vfe0_pix":0 []
                -> "msm_vfe1_pix":0 []
                -> "msm_vfe2_pix":0 []
                -> "msm_vfe3_pix":0 []

So that's consistent and this worked for me.

media-ctl --reset
media-ctl -v -d /dev/media0 -V '"imx577 '20-001a'":0[fmt:SRGGB10/4056x3040 field:none]'
media-ctl -V '"msm_csiphy2":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_csid0":0[fmt:SRGGB10/4056x3040]'
media-ctl -V '"msm_vfe0_rdi0":0[fmt:SRGGB10/4056x3040]'
media-ctl -l '"msm_csiphy2":1->"msm_csid0":0[1]'
media-ctl -l '"msm_csid0":1->"msm_vfe0_rdi0":0[1]'
build/yavta -B capture-mplane -c -I -n 5 -f SRGGB10P -s 4056x3040 -F /dev/video0

For the series.

Acked-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux