Hello. On Wed, 2010-09-08 at 20:35 +0200, ext Mauro Carvalho Chehab wrote: > > + case V4L2_CID_FM_BAND: return "FM Band"; > > There's no need for a FM control, as there's already an ioctl pair that allows get/set the frequency > bandwidth: VIDIOC_S_TUNER and VIDIOC_G_TUNER. So, the entire patch here seems uneeded/unwanted. Yes I agree, we can manage without having BAND support, but it isn't completely covered by VIDIOC_S_TUNER and VIDIOC_G_TUNER. Actually it would have had the biggest effect on the HW seek operation. For example without V4L2_CID_FM_BAND using wl1273 FM radio, which supports two bands, you need to do two seeks and band switch for every HW_SEEK IOCTL and those seeks are kind of slow operations to begin with. You have probably taken this into consideration but I wanted point this out anyway... Could the seek struct have a band indicator? B.R. Matti -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
