It was <2023-03-26 nie 16:31>, when Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> ---
> drivers/media/platform/samsung/s5p-g2d/g2d.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
Reviewed-by: Łukasz Stelmach <l.stelmach@xxxxxxxxxxx>
> diff --git a/drivers/media/platform/samsung/s5p-g2d/g2d.c b/drivers/media/platform/samsung/s5p-g2d/g2d.c
> index dd8864779a7c..89aeba47ed07 100644
> --- a/drivers/media/platform/samsung/s5p-g2d/g2d.c
> +++ b/drivers/media/platform/samsung/s5p-g2d/g2d.c
> @@ -740,7 +740,7 @@ static int g2d_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int g2d_remove(struct platform_device *pdev)
> +static void g2d_remove(struct platform_device *pdev)
> {
> struct g2d_dev *dev = platform_get_drvdata(pdev);
>
> @@ -753,7 +753,6 @@ static int g2d_remove(struct platform_device *pdev)
> clk_put(dev->gate);
> clk_unprepare(dev->clk);
> clk_put(dev->clk);
> - return 0;
> }
>
> static struct g2d_variant g2d_drvdata_v3x = {
> @@ -778,7 +777,7 @@ MODULE_DEVICE_TABLE(of, exynos_g2d_match);
>
> static struct platform_driver g2d_pdrv = {
> .probe = g2d_probe,
> - .remove = g2d_remove,
> + .remove_new = g2d_remove,
> .driver = {
> .name = G2D_NAME,
> .of_match_table = exynos_g2d_match,
--
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics
Attachment:
signature.asc
Description: PGP signature
