On Fri, Mar 31, 2023 at 10:08:43AM +0200, Hans Verkuil wrote: > On 29/03/2023 08:01, Greg Kroah-Hartman wrote: > > The pvrusb2 driver struct class logic was dynamically creating a class > > that should have just been static as it did not do anything special and > > was only a wrapper around a stock "struct class" implementation. Clean > > this all up by making a static struct class and modifying the code to > > correctly reference it. > > > > By doing so, lots of unneeded lines of code were removed, and #ifdef > > logic was cleaned up so that the .c files are not cluttered up with > > extra complexity following the proper kernel coding style. > > > > Cc: Mike Isely <isely@xxxxxxxxx> > > Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> > > Cc: linux-media@xxxxxxxxxxxxxxx > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > Reviewed-by: Hans Verkuil <hverkuil-cisco@xxxxxxxxx>a Great, thanks for the quick review. greg k-h
