On Wed, Mar 29, 2023 at 06:31:13PM +0200, Jacopo Mondi wrote: > > @@ -946,10 +954,10 @@ static int ccs_init_controls(struct ccs_sensor *sensor) > > > > sensor->hflip = v4l2_ctrl_new_std( > > &sensor->pixel_array->ctrl_handler, &ccs_ctrl_ops, > > - V4L2_CID_HFLIP, 0, 1, 1, default_flip); > > + V4L2_CID_HFLIP, 0, 1, 1, props.rotation == 180); > > Ah! ignore my comments on 1/2 :) > > Reviewed-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Thanks, Jacopo! Could you also check the documentation patch? I suppose we'll be good after this one? Or are there still drivers that have differing behaviour? -- Sakari Ailus
