On 3/27/23 02:42, Kieran Bingham wrote:
Quoting Uwe Kleine-König (2023-03-26 15:32:21)
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
Looks good to me.
Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
Mauro,
How would like to handle this patch in this 100+ patch series? I can
send pull request for it as usual. It might be easier for you to pull
this in with my Reviewed-by ? Let me know.
thanks,
-- Shuah
