Quoting Uwe Kleine-König (2023-03-26 15:31:25)
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
> ---
> drivers/media/platform/renesas/vsp1/vsp1_drv.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_drv.c b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> index 5710152d6511..c1c28f98bd10 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> @@ -977,7 +977,7 @@ static int vsp1_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int vsp1_remove(struct platform_device *pdev)
> +static void vsp1_remove(struct platform_device *pdev)
> {
> struct vsp1_device *vsp1 = platform_get_drvdata(pdev);
>
> @@ -985,8 +985,6 @@ static int vsp1_remove(struct platform_device *pdev)
> rcar_fcp_put(vsp1->fcp);
>
> pm_runtime_disable(&pdev->dev);
> -
> - return 0;
> }
>
> static const struct of_device_id vsp1_of_match[] = {
> @@ -999,7 +997,7 @@ MODULE_DEVICE_TABLE(of, vsp1_of_match);
>
> static struct platform_driver vsp1_platform_driver = {
> .probe = vsp1_probe,
> - .remove = vsp1_remove,
> + .remove_new = vsp1_remove,
> .driver = {
> .name = "vsp1",
> .pm = &vsp1_pm_ops,
> --
> 2.39.2
>
