Re: [PATCH 001/117] media: cros-ec-cec: Don't exit early in .remove() callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Sun, Mar 26, 2023 at 04:30:27PM +0200, Uwe Kleine-König wrote:
> Exiting early in remove without releasing all acquired resources yields
> leaks. Note that e.g. memory allocated with devm_zalloc() is freed after
> .remove() returns, even if the return code was negative.
> While blocking_notifier_chain_unregister() won't fail and so the
> change is somewhat cosmetic, platform driver's .remove callbacks are
> about to be converted to return void. To prepare that, keep the error
> message but don't return early.
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

I fatfingered sending out this series and this patch is a duplicate,
please ignore this patch, 002/117 with the otherwise same subject is the
right one. (They only differ in the number, this patch is advertised as
002 in the cover letter.)


Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | |

Attachment: signature.asc
Description: PGP signature

[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux