Hi Benjamin, I love your patch! Yet something to improve: [auto build test ERROR on media-tree/master] [also build test ERROR on linus/master v6.3-rc3 next-20230321] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Benjamin-Gaignard/media-videobuf2-Access-vb2_queue-bufs-array-through-helper-functions/20230321-183154 base: git://linuxtv.org/media_tree.git master patch link: https://lore.kernel.org/r/20230321102855.346732-2-benjamin.gaignard%40collabora.com patch subject: [PATCH v2 1/8] media: videobuf2: Access vb2_queue bufs array through helper functions config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230322/202303220154.ioaH1XLM-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/625d46c1c1fe8e3229a780134d21bcd4a017cfdd git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Benjamin-Gaignard/media-videobuf2-Access-vb2_queue-bufs-array-through-helper-functions/20230321-183154 git checkout 625d46c1c1fe8e3229a780134d21bcd4a017cfdd # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/staging/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303220154.ioaH1XLM-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/staging/media/atomisp/pci/atomisp_ioctl.c: In function 'atomisp_dqbuf_wrapper': >> drivers/staging/media/atomisp/pci/atomisp_ioctl.c:1098:33: error: incompatible type for argument 1 of 'vb2_get_buffer' 1098 | vb = vb2_get_buffer(pipe->vb_queue, buf->index); | ~~~~^~~~~~~~~~ | | | struct vb2_queue In file included from include/media/videobuf2-v4l2.h:16, from drivers/staging/media/atomisp//pci/ia_css_frame_public.h:23, from drivers/staging/media/atomisp/pci/sh_css_legacy.h:22, from drivers/staging/media/atomisp/pci/atomisp_internal.h:34, from drivers/staging/media/atomisp/pci/atomisp_cmd.h:30, from drivers/staging/media/atomisp/pci/atomisp_ioctl.c:27: include/media/videobuf2-core.h:1239:67: note: expected 'struct vb2_queue *' but argument is of type 'struct vb2_queue' 1239 | static inline struct vb2_buffer *vb2_get_buffer(struct vb2_queue *q, | ~~~~~~~~~~~~~~~~~~^ vim +/vb2_get_buffer +1098 drivers/staging/media/atomisp/pci/atomisp_ioctl.c 1083 1084 static int atomisp_dqbuf_wrapper(struct file *file, void *fh, struct v4l2_buffer *buf) 1085 { 1086 struct video_device *vdev = video_devdata(file); 1087 struct atomisp_video_pipe *pipe = atomisp_to_video_pipe(vdev); 1088 struct atomisp_sub_device *asd = pipe->asd; 1089 struct atomisp_device *isp = video_get_drvdata(vdev); 1090 struct ia_css_frame *frame; 1091 struct vb2_buffer *vb; 1092 int ret; 1093 1094 ret = vb2_ioctl_dqbuf(file, fh, buf); 1095 if (ret) 1096 return ret; 1097 > 1098 vb = vb2_get_buffer(pipe->vb_queue, buf->index); 1099 frame = vb_to_frame(vb); 1100 1101 buf->reserved = asd->frame_status[buf->index]; 1102 1103 /* 1104 * Hack: 1105 * Currently frame_status in the enum type which takes no more lower 1106 * 8 bit. 1107 * use bit[31:16] for exp_id as it is only in the range of 1~255 1108 */ 1109 buf->reserved &= 0x0000ffff; 1110 if (!(buf->flags & V4L2_BUF_FLAG_ERROR)) 1111 buf->reserved |= frame->exp_id; 1112 buf->reserved2 = pipe->frame_config_id[buf->index]; 1113 1114 dev_dbg(isp->dev, 1115 "dqbuf buffer %d (%s) for asd%d with exp_id %d, isp_config_id %d\n", 1116 buf->index, vdev->name, asd->index, buf->reserved >> 16, 1117 buf->reserved2); 1118 return 0; 1119 } 1120 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
