Re: [RFC 2/2] media: rkvdec: Add VP8 encoder

[Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx>]

Hi Daniel,

W dniu 19.03.2023 o 00:23, Daniel Almeida pisze:
> Hi Andrzej, one thing I noticed while looking at this:

Thanks for looking!

> > +struct hantro_vp8_entropy {
> > +	/* TODO: int32_t? */
> > +	int32_t coeff_prob[4][8][3][11];
> > +	int32_t coeff_prob_old[4][8][3][11];
> > +	int32_t mv_prob[2][19];
> > +	int32_t mv_prob_old[2][19];
> > +	int32_t y_mode_prob[4];
> > +	int32_t uv_mode_prob[3];
> > +};
> > >
>
> In VP9, probabilities are coded in the 0..255 range, so if you want to
> save space here, you can go with uint8_t.

Please note that this is a hardware-specific/driver-specific structure.
And, in particular, this is not a uAPI struct. The reference code uses
32-bit quantities hence int32_t here.

Andrzej

> -- Daniel