Hi Laurent,
Em Sun, 19 Mar 2023 02:34:23 +0000
Jenkins <jenkins@xxxxxxxxxxx> escreveu:
> checkpatch.pl:
> $ cat patches/0002-media-nxp-Add-i.MX8-ISI-driver.patch | formail -c | ./scripts/checkpatch.pl --terse --mailback --no-summary --strict
> -:98: WARNING: please write a help paragraph that fully describes the config symbol
> -:112: WARNING: please write a help paragraph that fully describes the config symbol
> -:761: WARNING: DT compatible string "fsl,imx8-isi" appears un-documented -- check ./Documentation/devicetree/bindings/
> -:1128: CHECK: Please use a blank line after function/struct/union/enum declarations
> -:1178: CHECK: Please use a blank line after function/struct/union/enum declarations
> -:1928: CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
There are still a couple of checkpatch issues there. Please check.
In special:
- either DT file is wrong or patch 2. Patch 1 declares:
properties:
compatible:
enum:
- fsl,imx8mn-isi
- fsl,imx8mp-isi
But patch 2 has an additional one:
static const struct of_device_id mxc_isi_of_match[] = {
{ .compatible = "fsl,imx8-isi", .data = &mxc_imx8_data_v1 },
{ .compatible = "fsl,imx8mn-isi", .data = &mxc_imx8mn_data },
{ .compatible = "fsl,imx8mp-isi", .data = &mxc_imx8mp_data },
{ /* sentinel */ },
- Instead of udelay(300, could it use, instead usleep_range()?
- There are two nitpick checkpatch warnings related to blank lines.
Thanks,
Mauro
