Hi,
Am Dienstag, 31. Januar 2023, 11:32:44 CET schrieb Alexander Stein:
> This simplifies the code and silences -517 error messages. Also
> the reason is listed in /sys/kernel/debug/devices_deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
is there any feedback on this?
Thanks and best regards,
Alexander
> ---
> drivers/media/platform/amphion/vpu_mbox.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/amphion/vpu_mbox.c
> b/drivers/media/platform/amphion/vpu_mbox.c index
> bf759eb2fd46..b6d5b4844f67 100644
> --- a/drivers/media/platform/amphion/vpu_mbox.c
> +++ b/drivers/media/platform/amphion/vpu_mbox.c
> @@ -46,11 +46,10 @@ static int vpu_mbox_request_channel(struct device *dev,
> struct vpu_mbox *mbox) cl->rx_callback = vpu_mbox_rx_callback;
>
> ch = mbox_request_channel_byname(cl, mbox->name);
> - if (IS_ERR(ch)) {
> - dev_err(dev, "Failed to request mbox chan %s, ret :
%ld\n",
> - mbox->name, PTR_ERR(ch));
> - return PTR_ERR(ch);
> - }
> + if (IS_ERR(ch))
> + return dev_err_probe(dev, PTR_ERR(ch),
> + "Failed to request mbox chan
%s\n",
> + mbox->name);
>
> mbox->ch = ch;
> return 0;
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
