On 14/03/2023 19:37, Krzysztof Kozlowski wrote: > On 06/02/2023 22:50, Rob Herring wrote: >> >> On Mon, 06 Feb 2023 21:23:16 +0100, Luca Weiss wrote: >>> Convert the text-based dt-bindings to yaml. >>> >>> Changes from original txt: >>> * Take wording for various properties from other yaml bindings, this >>> removes e.g. volt amount from schema since it isn't really relevant >>> and the datasheet is a better source. >>> * Don't make reset-gpios a required property since it can be tied to >>> DOVDD instead. >>> >>> Signed-off-by: Luca Weiss <luca@xxxxxxxxx> >>> --- >>> .../devicetree/bindings/media/i2c/ov2685.txt | 41 --------- >>> .../devicetree/bindings/media/i2c/ovti,ov2685.yaml | 101 +++++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 3 files changed, 102 insertions(+), 41 deletions(-) >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'clocks' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'clock-names' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'dvdd-supply' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'avdd-supply' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: 'dovdd-supply' is a required property >> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml > > These are errors from the bindings, so they must be fixed. If you do not > want to fix the rockchip bindings, just drop or replace the sensor in them. Or one more: add some fake stubs. They do not matter anyway... Best regards, Krzysztof
