On 13/03/2023 13:44, Hans Verkuil wrote: > Hi Daniel, > > On 07/03/2023 14:36, Daniel Lundberg Pedersen wrote: >> p_s32 and p_s64 were added to the v4l2_ext_control struct, so these >> should have documentation as well. > > This patch is missing your Signed-off-by line! > > Either repost or reply to this with your Signed-off-by. Sorry about that. Hope this is good enough. Signed-off-by: Daniel Lundberg Pedersen <dlp@xxxxxxxx> Regards Daniel > > It's a nice change, I'd like to merge this! > > Regards, > > Hans > >> --- >> .../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst >> index 892cfeb8b988..5292d5e1a91f 100644 >> --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst >> +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst >> @@ -185,6 +185,16 @@ still cause this situation. >> - ``p_u32`` >> - A pointer to a matrix control of unsigned 32-bit values. Valid if >> this control is of type ``V4L2_CTRL_TYPE_U32``. >> + * - __u32 * >> + - ``p_s32`` >> + - A pointer to a matrix control of signed 32-bit values. Valid if >> + this control is of type ``V4L2_CTRL_TYPE_INTEGER`` and >> + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. >> + * - __u32 * >> + - ``p_s64`` >> + - A pointer to a matrix control of signed 64-bit values. Valid if >> + this control is of type ``V4L2_CTRL_TYPE_INTEGER64`` and >> + ``V4L2_CTRL_FLAG_HAS_PAYLOAD`` is set. >> * - struct :c:type:`v4l2_area` * >> - ``p_area`` >> - A pointer to a struct :c:type:`v4l2_area`. Valid if this control is >
