On Thu, Mar 09, 2023 at 01:09:11PM +0100, Hans de Goede wrote:
> Hi Sakari,
>
> On 3/2/23 21:22, Sakari Ailus wrote:
> > Link validation currently accesses invalid pointers if the link passed to it
> > is not between two sub-devices. This is of course a driver bug.
> >
> > Ignore the error but print a debug message, as this is how it used to work
> > previously.
> >
> > Fixes: a6b995ed03ff ("media: subdev: use streams in v4l2_subdev_link_validate()")
> > Reported-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> > ---
> > Hi Hans,
> >
> > Could you test this?
>
> Yes, thank you for the fix.
>
> I can confirm that this fixes the oops on my Surface Go 1 and
> that it makes the IPU3 attached cameras work again:
>
> Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> or better just replace the Reported-by with:
>
> Reported-and-tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Thanks!
I'm putting this to my fixes PR I'm about to send soon.
--
Sakari Ailus
