Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/03/2023 16:18, Aakarsh Jain wrote:
>>
>> iommus:
>>   maxItems: 1
>> iommu-names: false
>>
> I am getting compilation errors with above property set and its breaking the bindings.
> If we see these two nodes in dtsi files.
>                mfc: codec@13400000 {
>                         compatible = "samsung,mfc-v5";
> ..
>                         iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
>                         iommu-names = "left", "right";
> }
> And 
>               mfc: codec@13400000 {
>                         compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
>                         reg = <0x13400000 0x10000>;
> ...
>                         iommus = <&sysmmu_mfc>;
>                 };
> There is no iommu-names property for compatible "samsung,exynos3250-mfc, samsung,mfc-v7", that’s why I kept
>         iommus:
>           minItems: 1
>           maxItems: 2
> I would even go with below if you agree?
>         iommus:
>           minItems: 1
>           maxItems: 2
>         iommus-names: false

No, I don't agree. Why do you need two IOMMUs for Exynos3250?
> 

Best regards,
Krzysztof




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux