On Wed, Feb 15, 2023 at 06:50:20PM +0200, Laurent Pinchart wrote: > Structures passed to subdev pad operations are all zero-initialized, but > not always with the same kind of code constructs. While most drivers > used designated initializers, which zero all the fields that are not > specified, when declaring variables, some use memset(). Those two > methods lead to the same end result, and, depending on compiler > optimizations, may even be completely equivalent, but they're not > consistent. > > Improve coding style consistency by using designated initializers > instead of calling memset(). Where applicable, also move the variables > to inner scopes of for loops to ensure correct initialization in all > iterations. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- [...] > drivers/staging/media/imx/imx-media-capture.c | 12 ++++++------ > drivers/staging/media/imx/imx-media-utils.c | 8 ++++---- Reviewed-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> regards Philipp
