On Thu, Mar 02, 2023 at 02:34:02PM +0800, zelong dong wrote:
> From: Zelong Dong <zelong.dong@xxxxxxxxxxx>
>
> Add the IR controller device of Meson-S4 SoC family, and enable
> hardware IR decoder.
>
> Signed-off-by: Zelong Dong <zelong.dong@xxxxxxxxxxx>
> ---
> .../boot/dts/amlogic/meson-s4-s805x2-aq222.dts | 6 ++++++
> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 16 ++++++++++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts b/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts
> index 8ffbcb2b1ac5..4d3a81b3b762 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-s4-s805x2-aq222.dts
> @@ -28,3 +28,9 @@ memory@0 {
> &uart_B {
> status = "okay";
> };
> +
> +&ir {
> + status = "disabled";
> + pinctrl-0 = <&remote_pins>;
> + pinctrl-names = "default";
> +};
I think dts and dtsi changes should be splitted to two different
patchsets.
Why do we need dts changes if ir node is disabled by default and you
don't enable it here?
[...]
--
Thank you,
Dmitry
