Re: [PATCH 0/3] media: Zero-initialize structures passed to subdev pad ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15/02/2023 18:50, Laurent Pinchart wrote:
Hello,

This patch series fixes a (surprisingly large) number of drivers that
don't zero-initialize structures passed to subdev pad operations.

The rationale is explained in patch 1/3, which fixes the issue: while
this doesn't cause any immediate problem, it leaves reserved fields
uninitialized, and any future change of in-kernel APIs that make use of
some of the reserved fields may introduce hard to catch breakages.

Patches 2/3 and 3/3 are not strictly required to fix the problem, but
they address coding style consistency issues that bothered me when
developing 1/3.

Laurent Pinchart (3):
   media: Zero-initialize all structures passed to subdev pad operations
   media: Prefer designated initializers over memset for subdev pad ops
   media: USe designated initializers for all subdev pad ops

For the three patches:

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

 Tomi




[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux