On 27/02/2023 12:38, Aakarsh Jain wrote: >>> + - samsung,mfc-v5 # Exynos4 >>> + - samsung,mfc-v6 # Exynos5 >>> + - items: >>> + - enum: >>> + - samsung,exynos3250-mfc # Exynos3250 >>> + - const: samsung,mfc-v7 # Fall back for Exynos3250 >>> + - enum: >>> + - samsung,mfc-v7 # Exynos5420 >>> + - samsung,mfc-v8 # Exynos5800 >>> + - samsung,exynos5433-mfc # Exynos5433 >>> + - samsung,mfc-v10 # Exynos7880 >> >> Why this and first enum are separate? I didn't notice it before... >> Usually we have only one enum for one-compatible variants. Also, sort them >> by compatible. >> > okay. > I will keep it in this way > properties: > compatible: > oneOf: > - const: samsung,mfc-v5 # Exynos4 > - const: samsung,mfc-v6 # Exynos5 > - const: samsung,mfc-v7 # Exynos5420 > - const: samsung,mfc-v8 # Exynos5800 > - const: samsung,exynos5433-mfc # Exynos5433 > - const: samsung,mfc-v10 # Exynos7880 These should still be an enum (and sorted by compatible). > - items: > - const: samsung,exynos3250-mfc # Exynos3250 > - const: samsung,mfc-v7 # Fall back for Exynos3250 > > Will this be fine? Best regards, Krzysztof
