On Tue, Sep 7, 2010 at 5:51 PM, David Härdeman <david@xxxxxxxxxxx> wrote: > This patch removes the remaining usages of the ir_input_nokey() and > ir_input_keydown() functions provided by drivers/media/IR/ir-functions.c > by using the corresponding functionality in rc-core directly instead. > > Signed-off-by: David Härdeman <david@xxxxxxxxxxx> Killing off legacy crud is a good thing. For a moment, I was confused by all the ir_type bits being removed, thinking those were still needed to populate allowed_protocols, but from reading through the patch in more detail, none of them are used for that. Then it dawned on me that (all of?) these are drivers that deal in scancodes, and allowed_protocols only really matters for raw IR drivers and scancode drivers that have a change_protocol function wired up. The only drivers that have that which the patch touches are saa7134-input.c and tm6000-input.c, and they're left intact, so all the ir_type bits removed are indeed completely unnecessary. That was a long-winded way of saying: Acked-by: Jarod Wilson <jarod@xxxxxxxxxx> -- Jarod Wilson jarod@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
