Re: [PATCH 4/4] media: i2c: st-vgxy61: Use VGXY61_NB_POLARITIES instead of hardcoded value in tx_from_ep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

On 2/14/23 00:01, Sakari Ailus wrote:
> Hi Benjamin,
> 
> On Wed, Feb 01, 2023 at 03:04:17PM +0100, Benjamin Mugnier wrote:
>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
> 
> I know this is a simple patch, but please add a commit message nonetheless.
> 
> Not having one produces a checkpatch.pl warning. Did you use it? :-)
> 

It's even worse, I remember using checkpatch.pl on the source file
directly but not on commits, so I missed it :'( I apologize.

Here is the long commit message:
tx_from_ep's for loop uses '5' as bound, while in fact it refers to the
number of polarities. Replace it by VGXY61_NB_POLARITIES for factorization.

Can you apply it directly to your tree, or do you want me to send a v2
with this fix?

Thanks a ton.

-- 
Regards,

Benjamin



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux