Hi Laurent, thanks for the wrap-up. I could test this series on my TQMa8MPxL (i.MX8MP) using ISP and libcamera as well. I think as well that we're good to go. Best regards, Alexander Am Mittwoch, 15. Februar 2023, 23:29:48 CET schrieb Laurent Pinchart: > Hello, > > This patch series combines the "[PATCH v2 0/2] Add support for mono > version of Sony IMX290 sensor" ([1]) and "[PATCH v2 00/13] imx290: Minor > fixes, support for alternate INCK, and more ctrls" ([2]) previously > submitted by Dave into a single series. > > As promised in my review of v2 of both series, I have tested the changes > with my IMX327 camera sensor, connected to the i.MX8MP ISP, with > libcamera. I haven't noticed any regression (but, full disclaimer, I > haven't tested all the newly features). I think we're thus good to go. > > This version handles all review comments from v2, resulting in the > following changes: > > - Deprecate the sony,imx290 compatible > - Update the DT example to use the new sony,imx290lqr compatible > - Drop unneeded pointer cast > - Don't move imx290_of_match table > - Fix typos > > The code has also been rebased on top of the latest media master branch, > with rebase conflicts and rebase-induced compilation breakages fixed. > > The patches are available from > > git://git.kernel.org/pub/scm/linux/kernel/git/pinchartl/linux.git > next/media/sensors/imx290 > > [1] > https://lore.kernel.org/linux-media/20230203191644.947643-1-dave.stevenson@ > raspberrypi.com [2] > https://lore.kernel.org/linux-media/20230203191811.947697-1-dave.stevenson@ > raspberrypi.com > > Dave Stevenson (15): > media: dt-bindings: media: i2c: Add mono version to IMX290 bindings > media: i2c: imx290: Add support for the mono sensor variant > media: i2c: imx290: Match kernel coding style on whitespace > media: i2c: imx290: Set the colorspace fields in the format > media: i2c: imx290: Add V4L2_SUBDEV_FL_HAS_EVENTS and subscribe hooks > media: i2c: imx290: Fix the pixel rate at 148.5Mpix/s > media: i2c: imx290: Support 60fps in 2 lane operation > media: i2c: imx290: Use CSI timings as per datasheet > media: i2c: imx290: Convert V4L2_CID_HBLANK to read/write > media: i2c: imx290: Convert V4L2_CID_VBLANK to read/write > media: i2c: imx290: VMAX is mode dependent > media: i2c: imx290: Remove duplicated write to IMX290_CTRL_07 > media: i2c: imx290: Add support for 74.25MHz external clock > media: i2c: imx290: Add support for H & V Flips > media: i2c: imx290: Add the error code to logs in start_streaming > > .../bindings/media/i2c/sony,imx290.yaml | 24 +- > drivers/media/i2c/imx290.c | 537 ++++++++++++++---- > 2 files changed, 442 insertions(+), 119 deletions(-) > > > base-commit: 83e0f265aa8d0e37cc8e15d318b64da0ec03ff41 -- TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht München, HRB 105018 Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider http://www.tq-group.com/
