Hi Niklas,
On Sat, Feb 11, 2023 at 4:05 PM Niklas Söderlund
<niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
> Prepare the driver for supporting R-Car Gen4. The starting of the
> receiver and how to enter standby differs between Gen3 and Gen4,
> create function pointers in the device info structure to control the
> different behavior.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-csi2.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-csi2.c
> @@ -1416,11 +1441,15 @@ static const struct rcar_csi2_info rcar_csi2_info_r8a77980 = {
> static const struct rcar_csi2_info rcar_csi2_info_r8a77990 = {
> .init_phtw = rcsi2_init_phtw_v3m_e3,
> .phy_post_init = rcsi2_phy_post_init_v3m_e3,
> + .start_receiver = rcsi2_start_receiver_gen3,
> + .enter_standby = rcsi2_enter_standby_gen3,
> .num_channels = 2,
> };
>
> static const struct rcar_csi2_info rcar_csi2_info_r8a779a0 = {
> .init_phtw = rcsi2_init_phtw_v3u,
> + .start_receiver = rcsi2_start_receiver_gen3,
> + .enter_standby = rcsi2_enter_standby_gen3,
This part means R-Car V3U is still treated like other R-Car Gen3 SoCs,
not like R-Car Gen4. Just double-checking if that is intentional?
> .hsfreqrange = hsfreqrange_v3u,
> .csi0clkfreqrange = 0x20,
> .clear_ulps = true,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
