On 2/8/23 10:06, Javier Martinez Canillas wrote: > Hello Vikash, > > On 2/7/23 17:40, Vikash Garodia wrote: >> Hi Javier and Matthias, >> Can we try the attached patch if that fixes the suspend issue for sc7180 and sc7280 ? >> > > I tested your attached patch on an SC7180 machine (HP X2 Chromebook) and as Matthias > mentioned, it still causes the driver's probe to fail: > > [ 2119.063779] qcom-venus aa00000.video-codec: non legacy binding > [ 2119.085695] platform video-firmware.0: Adding to iommu group 11 > [ 2119.156302] arm-smmu 15000000.iommu: Unhandled context fault: fsr=0x402, iova=0x000000b0, fsynr=0x61, cbfrsynra=0xc40, cb=7 > [ 2119.259382] qcom-venus aa00000.video-codec: failed to reset venus core > [ 2119.267782] platform video-firmware.0: Removing from iommu group 11 > [ 2119.275052] qcom-venus: probe of aa00000.video-codec failed with error -110 > So what should we do about this folks? Since not allowing the driver to probe on at least SC7180 is a quite serious regression, can we revert for now until a proper fix is figured out? -- Best regards, Javier Martinez Canillas Core Platforms Red Hat