Hi Sakari, https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Sakari-Ailus/ACPI-property-Parse-data-node-string-references-in-properties/20230209-053017 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20230208212712.3184953-3-sakari.ailus%40linux.intel.com patch subject: [PATCH v5 2/8] ACPI: property: Parse _CRS CSI-2 descriptor config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230209/202302091722.YCT7d1kl-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Reported-by: Dan Carpenter <error27@xxxxxxxxx> | Link: https://lore.kernel.org/r/202302091722.YCT7d1kl-lkp@xxxxxxxxx smatch warnings: drivers/acpi/mipi.c:241 acpi_crs_csi2_alloc_fill_swnodes() warn: variable dereferenced before check 'ads' (see line 237) vim +/ads +241 drivers/acpi/mipi.c 06167f6b99bad9 Sakari Ailus 2023-02-08 206 void acpi_crs_csi2_alloc_fill_swnodes(size_t ports_count, acpi_handle handle) 06167f6b99bad9 Sakari Ailus 2023-02-08 207 { 06167f6b99bad9 Sakari Ailus 2023-02-08 208 struct acpi_device_software_nodes *ads; 06167f6b99bad9 Sakari Ailus 2023-02-08 209 struct crs_csi2_swnodes *swnodes; 06167f6b99bad9 Sakari Ailus 2023-02-08 210 size_t alloc_size; 06167f6b99bad9 Sakari Ailus 2023-02-08 211 unsigned int i; 06167f6b99bad9 Sakari Ailus 2023-02-08 212 bool overflow; 06167f6b99bad9 Sakari Ailus 2023-02-08 213 void *end; 06167f6b99bad9 Sakari Ailus 2023-02-08 214 06167f6b99bad9 Sakari Ailus 2023-02-08 215 /* 06167f6b99bad9 Sakari Ailus 2023-02-08 216 * Allocate memory for ports, node pointers (number of nodes + 06167f6b99bad9 Sakari Ailus 2023-02-08 217 * 1 (guardian), nodes (root + number of ports * 2 (for for 06167f6b99bad9 Sakari Ailus 2023-02-08 218 * every port there is an endpoint)). 06167f6b99bad9 Sakari Ailus 2023-02-08 219 */ 06167f6b99bad9 Sakari Ailus 2023-02-08 220 overflow = check_mul_overflow(sizeof(*ads->ports) + 06167f6b99bad9 Sakari Ailus 2023-02-08 221 sizeof(*ads->nodes) * 2 + 06167f6b99bad9 Sakari Ailus 2023-02-08 222 sizeof(*ads->nodeptrs) * 2, 06167f6b99bad9 Sakari Ailus 2023-02-08 223 ports_count, &alloc_size); 06167f6b99bad9 Sakari Ailus 2023-02-08 224 overflow = overflow || 06167f6b99bad9 Sakari Ailus 2023-02-08 225 check_add_overflow(sizeof(*ads) + sizeof(*ads->nodes) + 06167f6b99bad9 Sakari Ailus 2023-02-08 226 sizeof(*ads->nodeptrs) * 2, 06167f6b99bad9 Sakari Ailus 2023-02-08 227 alloc_size, &alloc_size); 06167f6b99bad9 Sakari Ailus 2023-02-08 228 if (overflow) { 06167f6b99bad9 Sakari Ailus 2023-02-08 229 acpi_handle_warn(handle, 06167f6b99bad9 Sakari Ailus 2023-02-08 230 "too many _CRS CSI2 resource handles (%zu)", 06167f6b99bad9 Sakari Ailus 2023-02-08 231 ports_count); 06167f6b99bad9 Sakari Ailus 2023-02-08 232 return; 06167f6b99bad9 Sakari Ailus 2023-02-08 233 } 06167f6b99bad9 Sakari Ailus 2023-02-08 234 06167f6b99bad9 Sakari Ailus 2023-02-08 235 swnodes = kzalloc(sizeof(*swnodes), GFP_KERNEL); 06167f6b99bad9 Sakari Ailus 2023-02-08 236 ads = kzalloc(alloc_size, GFP_KERNEL); 06167f6b99bad9 Sakari Ailus 2023-02-08 @237 ads->ports = (void *)(ads + 1); ^^^^^^^^^^ Derference 06167f6b99bad9 Sakari Ailus 2023-02-08 238 ads->nodes = (void *)(ads->ports + ports_count); 06167f6b99bad9 Sakari Ailus 2023-02-08 239 ads->nodeptrs = (void *)(ads->nodes + ports_count * 2 + 1); 06167f6b99bad9 Sakari Ailus 2023-02-08 240 end = ads->nodeptrs + ports_count * 2 + 2; 06167f6b99bad9 Sakari Ailus 2023-02-08 @241 if (!swnodes || !ads || WARN_ON((void *)ads + alloc_size != end)) { ^^^^ Checked to late. 06167f6b99bad9 Sakari Ailus 2023-02-08 242 kfree(swnodes); 06167f6b99bad9 Sakari Ailus 2023-02-08 243 kfree(ads); 06167f6b99bad9 Sakari Ailus 2023-02-08 244 acpi_handle_debug(handle, 06167f6b99bad9 Sakari Ailus 2023-02-08 245 "cannot allocate for %zu software nodes\n", 06167f6b99bad9 Sakari Ailus 2023-02-08 246 ports_count); 06167f6b99bad9 Sakari Ailus 2023-02-08 247 return; 06167f6b99bad9 Sakari Ailus 2023-02-08 248 } 06167f6b99bad9 Sakari Ailus 2023-02-08 249 06167f6b99bad9 Sakari Ailus 2023-02-08 250 ads->num_ports = ports_count; 06167f6b99bad9 Sakari Ailus 2023-02-08 251 for (i = 0; i < ports_count * 2 + 1; i++) 06167f6b99bad9 Sakari Ailus 2023-02-08 252 ads->nodeptrs[i] = &ads->nodes[i]; 06167f6b99bad9 Sakari Ailus 2023-02-08 253 ads->nodeptrs[i] = NULL; 06167f6b99bad9 Sakari Ailus 2023-02-08 254 for (i = 0; i < ports_count; i++) 06167f6b99bad9 Sakari Ailus 2023-02-08 255 ads->ports[i].port_nr = NO_CSI2_PORT; 06167f6b99bad9 Sakari Ailus 2023-02-08 256 swnodes->handle = handle; 06167f6b99bad9 Sakari Ailus 2023-02-08 257 swnodes->ads = ads; 06167f6b99bad9 Sakari Ailus 2023-02-08 258 list_add(&swnodes->list, &crs_csi2_swnodes); 06167f6b99bad9 Sakari Ailus 2023-02-08 259 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
