Re: [PATCH 1/5] rc-code: merge and rename ir-core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em 07-09-2010 18:51, David Härdeman escreveu:
> This patch merges the files which makes up ir-core and renames the
> resulting module to rc-core. IMHO this makes it much easier to hack
> on the core module since all code is in one file.
> 
> This also allows some simplification of ir-core-priv.h as fewer internal
> functions need to be exposed.

I'm not sure about this patch. Big files tend to be harder to maintain,
as it takes more time to find the right functions inside it. Also, IMO, 
it makes sense to keep the raw-event code on a separate file.

Anyway, if we apply this patch right now, it will cause merge conflicts with
the input tree, due to the get/setkeycodebig patches, and with some other
patches that are pending merge/review. The better is to apply such patch
just after the release of 2.6.37-rc1, after having all those conflicts
solved.

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux