Hi Dave, Thank you for the patch. On Tue, Jan 31, 2023 at 07:20:07PM +0000, Dave Stevenson wrote: > The colorspace fields were left untouched in imx290_set_fmt > which lead to a v4l2-compliance failure. > > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> > --- > drivers/media/i2c/imx290.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c > index 88c7201510a2..bf96fd914303 100644 > --- a/drivers/media/i2c/imx290.c > +++ b/drivers/media/i2c/imx290.c > @@ -897,6 +897,14 @@ static int imx290_set_fmt(struct v4l2_subdev *sd, > fmt->format.code = imx290_formats[0].code[imx290->mono]; > > fmt->format.field = V4L2_FIELD_NONE; > + fmt->format.colorspace = V4L2_COLORSPACE_RAW; > + fmt->format.ycbcr_enc = > + V4L2_MAP_YCBCR_ENC_DEFAULT(fmt->format.colorspace); > + fmt->format.quantization = > + V4L2_MAP_QUANTIZATION_DEFAULT(true, fmt->format.colorspace, > + fmt->format.ycbcr_enc); > + fmt->format.xfer_func = > + V4L2_MAP_XFER_FUNC_DEFAULT(fmt->format.colorspace); Given that all of these are hardcoded, I think it would be more readable to write fmt->format.colorspace = V4L2_COLORSPACE_RAW; fmt->format.ycbcr_enc = V4L2_YCBCR_ENC_601; fmt->format.quantization = V4L2_QUANTIZATION_FULL_RANGE; fmt->format.xfer_func = V4L2_XFER_FUNC_NONE; > format = v4l2_subdev_get_pad_format(sd, sd_state, 0); -- Regards, Laurent Pinchart
