On Tuesday, September 07, 2010 19:57:18 Jean-Francois Moine wrote: > On Tue, 7 Sep 2010 17:30:33 +0200 > Hans Verkuil <hverkuil@xxxxxxxxx> wrote: > > > enum v4l2_illuminator { > > V4L2_ILLUMINATOR_OFF = 0, > > V4L2_ILLUMINATOR_ON = 1, > > }; > > #define V4L2_CID_ILLUMINATOR_0 (V4L2_CID_BASE+37) > > #define V4L2_CID_ILLUMINATOR_1 (V4L2_CID_BASE+38) > > > > enum v4l2_led { > > V4L2_LED_AUTO = 0, > > V4L2_LED_OFF = 1, > > V4L2_LED_ON = 2, > > }; > > #define V4L2_CID_LED_0 (V4L2_CID_BASE+39) > > > > Simple and straightforward. > > Hi, > > Hans (de Goede), is this OK for you? I think that if we find more > illuminators or LEDs on some devices, we may add more V4L2_CID_xxx_n > controls. > > Hans (Verkuil), may we have the same enum's for both light types? > Something like: > > enum v4l2_light { > V4L2_LIGHT_OFF = 0, > V4L2_LIGHT_ON = 1, > V4L2_LIGHT_AUTO = 2, > V4L2_LIGHT_BLINK = 3, > }; I'm OK with that. Although 'blink' shouldn't be added yet unless we have a driver that will actually make use of it. Regards, Hans > > Regards. > > -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html