Re: [PATCH] media: c8sectpfe: convert to gpio descriptors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 31, 2023 at 07:29:37PM -0800, Dmitry Torokhov wrote:
> On Mon, Jan 30, 2023 at 5:31 AM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:

...

> > +               tsin->rst_gpio = devm_fwnode_gpiod_get_index(dev,
> > +                                                            of_node_to_fwnode(child),

Actually, please use of_fwnode_handle() and not IRQ framework custom grown
duplicate.

> > +                                                            "reset-gpios",
> 
> Wrong name.
> 
> > +                                                            0, GPIOD_OUT_LOW,
> > +                                                            "NIM reset");

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux