On Tuesday, September 07, 2010 11:44:18 Hans de Goede wrote: > Replying to myself. > > On 09/07/2010 11:42 AM, Hans de Goede wrote: > > Hi, > > > > On 09/07/2010 09:30 AM, Hans Verkuil wrote: > >> On Monday, September 06, 2010 20:11:05 Jean-Francois Moine wrote: > >>> Hi, > >>> > >>> This new proposal cancels the previous 'LED control' patch. > >>> > >>> Cheers. > >>> > >>> > >> > >> Hi Jean-Francois, > >> > >> You must also add support for these new controls in v4l2-ctrls.c in > >> v4l2_ctrl_get_menu(), v4l2_ctrl_get_name() and v4l2_ctrl_fill(). > >> > >> How is CID_ILLUMINATORS supposed to work in the case of multiple lights? > >> Wouldn't a bitmask type be more suitable to this than a menu type? There > >> isn't a bitmask type at the moment, but this seems to be a pretty good > >> candidate for a type like that. > >> > >> Actually, for the status led I would also use a bitmask since there may be > >> multiple leds. I guess you would need two bitmasks: one to select auto vs > >> manual, and one for the manual settings. > >> > > > > So far I've not seen cameras with multiple status leds, I do have seen camera > > which have the following settings for their 1 led (logitech uvc cams): > > auto > > on > > off > > blinking > > > > So I think a menu type is better suited, and that is what the current (private) > > uvc control uses. > > The same argument more or less goes for the CID_ILLIMUNATORS controls. Also given > that we currently don't have a bitmask type I think introducing one without a really > really good reason is a bad idea as any exiting apps won't know how to deal with it. But I can guarantee that we will get video devices with multiple leds in the future. So we need to think *now* about how to do this. One simple option is of course to name the controls CID_ILLUMINATOR0 and CID_LED0. That way we can easily add LED1, LED2, etc. later without running into weird inconsistent control names. Regards, Hans -- Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
