Am Sonntag, dem 29.01.2023 um 04:34 +0200 schrieb Laurent Pinchart: > Hello, > > This small series moves the imx7-mipi-csi driver to use the subdev > active state. Patches 1/8 to 7/8 are small preparatory cleanups, with > the main change in 8/8. > > Compared to v1, I've now successfully tested the series on an > i.MX8MM. > The issues reported by Adam have been resolved by adding patch 7/8 > and > fixing a problem in 8/8. > > Laurent Pinchart (8): > media: imx: imx7-media-csi: Drop imx7_csi.cc field > media: imx: imx7-media-csi: Simplify imx7_csi_video_init_format() > media: imx: imx7-media-csi: Drop unneeded check when starting > streaming > media: imx: imx7-media-csi: Drop unneeded src_sd check > media: imx: imx7-media-csi: Drop unneeded pad checks > media: imx: imx7-media-csi: Cleanup errors in > imx7_csi_async_register() > media: imx: imx7-media-csi: Zero format struct before calling > .get_fmt() > media: imx: imx7-media-csi: Use V4L2 subdev active state > > drivers/media/platform/nxp/imx7-media-csi.c | 235 ++++++------------ > -- > 1 file changed, 70 insertions(+), 165 deletions(-) > hi Laurent, what tree did you base this on? onto v6.2-rc6 I have a change missing: in imx7_csi_video_validate_fmt(), before calling v4l2_subdev_call_state_active(), there's fmt_src.pad and fmt_src.which assigned. I don't have that. thanks martin