Hey Laurent, Thanks for all the cleanups and updates. Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> writes: > Hello, > > This small series moves the imx-mipi-csis driver to use the subdev > active state. Patches 1/5 to 3/5 are small preparatory cleanups, with > the main change in 4/5. Patch 5/5 is further cleanup that could have > been included in 4/5, but that should be easier to review as a separate > patch. > > The series has been tested on the i.MX8MP with the ISI, and IMX296 and > IMX327 camera sensors. > > Laurent Pinchart (5): > media: imx-mipi-csis: Rename error labels with 'err_' prefix > media: imx-mipi-csis: Don't take lock in runtime PM handlers > media: imx-mipi-csis: Pass format explicitly to internal functions > media: imx-mipi-csis: Use V4L2 subdev active state > media: imx-mipi-csis: Implement .init_cfg() using .set_fmt() LGTM, for the all series. Acked-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx> Cheers, Rui > > drivers/media/platform/nxp/imx-mipi-csis.c | 249 +++++++++------------ > 1 file changed, 103 insertions(+), 146 deletions(-) > > -- > Regards, > > Laurent Pinchart