Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.2-rc5] [cannot apply to media-tree/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/media-v4l2-core-Make-the-v4l2-core-code-enable-disable-the-privacy-LED-if-present/20230128-131233 patch link: https://lore.kernel.org/r/20230127203729.10205-4-hdegoede%40redhat.com patch subject: [PATCH v6 3/5] platform/x86: int3472/discrete: Create a LED class device for the privacy LED config: i386-randconfig-r004-20230123 (https://download.01.org/0day-ci/archive/20230128/202301281537.fKVHsgf4-lkp@xxxxxxxxx/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/d71a1bce9c9ea0bd5b98920b2d72a5b0a36ca19d git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Hans-de-Goede/media-v4l2-core-Make-the-v4l2-core-code-enable-disable-the-privacy-LED-if-present/20230128-131233 git checkout d71a1bce9c9ea0bd5b98920b2d72a5b0a36ca19d # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from drivers/platform/x86/intel/int3472/discrete.c:17: >> drivers/platform/x86/intel/int3472/common.h:107:40: error: field 'lookup' has incomplete type 107 | struct led_lookup_data lookup; | ^~~~~~ -- In file included from drivers/platform/x86/intel/int3472/led.c:7: >> drivers/platform/x86/intel/int3472/common.h:107:40: error: field 'lookup' has incomplete type 107 | struct led_lookup_data lookup; | ^~~~~~ drivers/platform/x86/intel/int3472/led.c: In function 'skl_int3472_register_pled': >> drivers/platform/x86/intel/int3472/led.c:57:9: error: implicit declaration of function 'led_add_lookup'; did you mean 'd_can_lookup'? [-Werror=implicit-function-declaration] 57 | led_add_lookup(&int3472->pled.lookup); | ^~~~~~~~~~~~~~ | d_can_lookup drivers/platform/x86/intel/int3472/led.c: In function 'skl_int3472_unregister_pled': >> drivers/platform/x86/intel/int3472/led.c:71:9: error: implicit declaration of function 'led_remove_lookup' [-Werror=implicit-function-declaration] 71 | led_remove_lookup(&int3472->pled.lookup); | ^~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/lookup +107 drivers/platform/x86/intel/int3472/common.h 80 81 struct int3472_discrete_device { 82 struct acpi_device *adev; 83 struct device *dev; 84 struct acpi_device *sensor; 85 const char *sensor_name; 86 87 const struct int3472_sensor_config *sensor_config; 88 89 struct int3472_gpio_regulator { 90 char regulator_name[GPIO_REGULATOR_NAME_LENGTH]; 91 char supply_name[GPIO_REGULATOR_SUPPLY_NAME_LENGTH]; 92 struct gpio_desc *gpio; 93 struct regulator_dev *rdev; 94 struct regulator_desc rdesc; 95 } regulator; 96 97 struct int3472_gpio_clock { 98 struct clk *clk; 99 struct clk_hw clk_hw; 100 struct clk_lookup *cl; 101 struct gpio_desc *ena_gpio; 102 u32 frequency; 103 } clock; 104 105 struct int3472_pled { 106 struct led_classdev classdev; > 107 struct led_lookup_data lookup; 108 char name[INT3472_LED_MAX_NAME_LEN]; 109 struct gpio_desc *gpio; 110 } pled; 111 112 unsigned int ngpios; /* how many GPIOs have we seen */ 113 unsigned int n_sensor_gpios; /* how many have we mapped to sensor */ 114 struct gpiod_lookup_table gpios; 115 }; 116 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
