Am 26.01.23 um 23:25 schrieb Danilo Krummrich:
On 1/26/23 07:58, Christian König wrote:
Am 26.01.23 um 01:28 schrieb Danilo Krummrich:
In dma_fence_allocate_private_stub() set the signaling bit of the newly
allocated private stub fence rather than the signaling bit of the
shared dma_fence_stub.
Fixes: c85d00d4fd8b ("dma-buf: set signaling bit for the stub fence")
Signed-off-by: Danilo Krummrich <dakr@xxxxxxxxxx>
Good catch, Reviewed-by: Christian König <christian.koenig@xxxxxxx>
Should I push it upstream as well or do you have commit access?
Thanks, I can push it to drm-misc-next.
This is clearly a bug fix so better push this to drm-misc-fixes and
maybe even add a CC:stable tag.
Christian.
---
drivers/dma-buf/dma-fence.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 406b4e26f538..0de0482cd36e 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -167,7 +167,7 @@ struct dma_fence
*dma_fence_allocate_private_stub(void)
0, 0);
set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
- &dma_fence_stub.flags);
+ &fence->flags);
dma_fence_signal(fence);