On 26/01/2023 01:33, Laurent Pinchart wrote: > The Image Sensing Interface (ISI) combines image processing pipelines > with DMA engines to process and capture frames originating from a > variety of sources. The inputs to the ISI go through Pixel Link > interfaces, and their number and nature is SoC-dependent. They cover > both capture interfaces (MIPI CSI-2 RX, HDMI RX) and memory inputs. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > Changes since v2: > > - Describe the interrupts property > - Set global minItems and maxItems for interrupts Thank you for your patch. There is something to discuss/improve. > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + description: | > + Ports represent the Pixel Link inputs to the ISI. Their number and > + assignment are model-dependent. Each port shall have a single endpoint. > + > + patternProperties: > + "^port@[0-9]$": > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false You should not need this. The ports from graph.yaml already have it and you do not bring here any additional information (like description or how many ports are valid). I propose to just drop it or extend with some of information. > + > + unevaluatedProperties: false > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - fsl,blk-ctrl > + - ports > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mn-isi > + then: > + properties: > + interrupts: > + maxItems: 1 > + ports: > + properties: > + port@0: > + description: MIPI CSI-2 RX > + required: > + - port@0 Best regards, Krzysztof
