On 1/25/23 00:14, Luca Ceresoli wrote: > Hi Dmitry, > > On Tue, 24 Jan 2023 20:02:39 +0300 > Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> wrote: > >> On 12/29/22 16:31, Luca Ceresoli wrote: >>> + vip { >>> + compatible = "nvidia,tegra20-vip"; >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + channel@0 { >>> + reg = <0>; >>> + ports { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + port@0 { >>> + reg = <0>; >>> + vi_vip_in: endpoint { >>> + remote-endpoint = <&mt9v111_out>; >>> + }; >>> + }; >>> + port@1 { >>> + reg = <1>; >>> + vi_vip_out: endpoint { >>> + remote-endpoint = <&vi_in>; >>> + }; >>> + }; >>> + }; >>> + }; >> >> In the changelog you said that the channel@0 node is removed > > Thanks, you are right, this is a leftover. I must have forgotten about > updating the example. :-\ > > It will be fixed in v4 obviously, I was waiting before sending it in > case of any feedback on the other patches. The rest of the patches look okay. The patchset should get testing on T210 and then will be good to apply it, IMO. If nobody will volunteer to test T210 then should be good to apply it too, we can always fix the code later on. -- Best regards, Dmitry