On Sun, 2010-09-05 at 10:24 +0200, Hans de Goede wrote: > Hi, > > p.s. (forgot to mention this in my previous mail) > > On 09/03/2010 03:09 AM, Andy Walls wrote: > > <snip> > > > @@ -447,6 +449,20 @@ > > .set = sd_setcomptarget, > > .get = sd_getcomptarget, > > }, > > + { > > + { > > +#define V4L2_CID_LAMPS (V4L2_CID_PRIVATE_BASE+1) > > + .id = V4L2_CID_LAMPS, > > + .type = V4L2_CTRL_TYPE_MENU, > > + .name = "Lamps", > > + .minimum = 0, > > + .maximum = 3, > > + .step = 1, > > + .default_value = 0, > > + }, > > + .set = sd_setlamps, > > + .get = sd_getlamps, > > + }, > > }; > > > > static const struct v4l2_pix_format mode[] = { > > We only want this control to be available on the qx3 and not on > all cpia1 devices, Yes, I though about that, but couldn't think up a clean way of doing it in the short amount of time I had available. I did know that the control was essentially a NoOp, so I wasn't too concerned at the time. > so you need to add something like the following to > sd_config: > > if (!(id->idVendor == 0x0813 && id->idProduct == 0x0001)) > gspca_dev->ctrl_dis = 1 << LAMPS_IDX; > > Where LAMPS_IDX is a define giving the index of V4L2_CID_LAMPS in the > sd_ctrls array, see the ov519 gspca driver for example. Thanks for the pointer, I'll have a look. Regards, Andy > Regards, > > Hans -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html